Fixed the "-- Comment" SQL case (Fixes #1066)#1067
Open
dsevilla wants to merge 7 commits intoploomber:masterfrom
Open
Fixed the "-- Comment" SQL case (Fixes #1066)#1067dsevilla wants to merge 7 commits intoploomber:masterfrom
dsevilla wants to merge 7 commits intoploomber:masterfrom
Conversation
Two fixes where added: - The "-- Comment" case - The "begin" transaction was checked only at the beginning of the %%sql block, not for each statement. I fixed it, but I'm not sure how it does work at the already executed queries. This test should be performed earlier similar to what I changed to fix ploomber#1066.
Author
|
Any work on this? I've seen that the problem of the merge is caused by other parts of the code failing with recent versions of SQL Alchemy. Should I contribute to fix these too? |
|
hi @dsevilla, yeah if you can help fix the CI, that'd be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes where added:
Describe your changes
Issue number
Closes #1066
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--1067.org.readthedocs.build/en/1067/